Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Inconsistency in specifying S0 values in multi_tensor and single_tensor #1061
In dipy/sims/voxel.py multi_tensor specifies S0=100 while single_tensor specifies S0=1
Should it be consistent over both functions ?
Yes. Best to set a global variable, and then use it in all the function definitions. There are many places in which this is set to 100, and only a few in which this is set to 1, so I guess we should probably go with 100 everywhere. There's even (at least) one place where S0 is set to 150... (https://github.com/nipy/dipy/blob/master/dipy/sims/voxel.py#L484)