New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in specifying S0 values in multi_tensor and single_tensor #1061

Closed
sahmed95 opened this Issue May 26, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@sahmed95
Contributor

sahmed95 commented May 26, 2016

As pointed out by @etpeterson in #1058 (comment)

Looks like dipy may be a little conflicted also. Single_tensor uses S0=1 and multi_tensor uses S0=100, though others seem to prefer the 100 area.

In dipy/sims/voxel.py multi_tensor specifies S0=100 while single_tensor specifies S0=1

Should it be consistent over both functions ?

@arokem

This comment has been minimized.

Member

arokem commented May 27, 2016

Yes. Best to set a global variable, and then use it in all the function definitions. There are many places in which this is set to 100, and only a few in which this is set to 1, so I guess we should probably go with 100 everywhere. There's even (at least) one place where S0 is set to 150... (https://github.com/nipy/dipy/blob/master/dipy/sims/voxel.py#L484)

@sahmed95

This comment has been minimized.

Contributor

sahmed95 commented May 27, 2016

PR for the fix : #1063

@sahmed95 sahmed95 referenced this issue May 30, 2016

Merged

IVIM #1058

@arokem arokem closed this in 330f95b Jul 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment