New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.eddy_rotated_bvecs file throws error from io.gradients read_bvals_bvecs function #1117

Closed
mrjeffs opened this Issue Sep 9, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@mrjeffs

mrjeffs commented Sep 9, 2016

after using fsl eddy the resulting bvecs file ext becomes .eddy_rotated_bvecs
when read_bvals_bvecs reads the newly created .eddy_rotated_bvecs it tests the extension
if ext in ['.bvals', '.bval', '.bvecs', '.bvec', '.txt', '']:
i modified it to
if ext in ['.bvals', '.bval', '.bvecs', '.bvec', '.txt', '.eddy_rotated_bvecs', '']:
and it seemed to work without error.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Oct 5, 2016

Okay good. Can you make a pull request @mrjeffs with that addition? It is a bit strange to change the end of the filename in this way. But I think we should support it.

@mrjeffs

This comment has been minimized.

mrjeffs commented Oct 5, 2016

great thanks. will do. FSL eddy chooses not to overwrite the orig bvecs when it recalculates vectors.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Oct 6, 2016

They should have done something like filename_eddy_rotated.bvecs
Anyway... :)

@skoudoro

This comment has been minimized.

Member

skoudoro commented Feb 6, 2018

done on #1411

@skoudoro skoudoro closed this Feb 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment