New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildbots failing with workflow merge #1119

Closed
arokem opened this Issue Sep 16, 2016 · 6 comments

Comments

Projects
None yet
2 participants
@matthieudumont

This comment has been minimized.

Contributor

matthieudumont commented Sep 16, 2016

WIll look into it

@matthieudumont

This comment has been minimized.

Contributor

matthieudumont commented Sep 16, 2016

Does the build only fail on osx?

It might have to do with os.path.getmtime not working the same on osx. (dont have an osx machine to test it right now).

@arokem

This comment has been minimized.

Member

arokem commented Sep 16, 2016

Thanks for taking a look! Indeed, it seems to be an OSX thing. You can see the status of all the bots here:

http://nipy.bic.berkeley.edu/waterfall

Also, it is failing locally on my laptop (a mac). I'll try to see if I can find a fix on my setup.

@arokem

This comment has been minimized.

Member

arokem commented Sep 16, 2016

I think I get it. It's because too little time passes between the second time and third time through. getmtime gives you back the time in seconds since the epoch, so if the time elapsed between the runs is less than a second, you get back the same time. PR fixing this to follow. I also had introduced several PEP8 fixes all over, and some clarifications to the documentation. Including some questions with "XXX" that I would like to answer, before we merge this fix.

@arokem arokem referenced this issue Sep 16, 2016

Merged

Fix 1119 #1120

@arokem

This comment has been minimized.

Member

arokem commented Sep 16, 2016

@arokem

This comment has been minimized.

Member

arokem commented Dec 16, 2016

Looks like this was fixed in #1120

@arokem arokem closed this Dec 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment