New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few broken builds #1138

Closed
arokem opened this Issue Nov 1, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@nilgoyette

This comment has been minimized.

Contributor

nilgoyette commented Nov 16, 2016

I think it's related to the problem described here: "The libc math library is special in that it is not linked by default on some Unix-like systems, such as Linux."

I reproduced the problem in Windows.

  • I tried adding the libraries=["m"] parameter but m.lib doesn't exist on Windows. Or math.lib, or cmath.lib, etc. I don't really know what to write here.
  • I tried redeclaring fmin with cdef extern from "math.h" nogil: but it stays undefined. Anyway, we can clearly see that it's defined in cython so we shouldn't have to do that.

This being said, I was not able to fix it on my computer. Anyone known how?

@matthew-brett

This comment has been minimized.

Member

matthew-brett commented Nov 16, 2016

This may be relevant : http://stackoverflow.com/questions/19234452/visual-c-express-fmin-and-fmax-identifier-not-found#19234517

fmin and fmax are a C99 feature. Visual Studio only implements the C89 standard, so it doesn't have that functions.

Maybe you could do something like this in src/dpy_math.h:

#if (defined(WIN32) || defined(_WIN64)) && !defined(__GNUC__)
#define fmin min
#endif

Then in the pyx file:

cdef extern from "dpy_math.h" nogil:
    double fmin(double x)

or similar. @omarocegueda may better remember our struggles on this kind of thing back in the day.

@arokem

This comment has been minimized.

Member

arokem commented Dec 16, 2016

This is addressed in #1151

@arokem arokem closed this Dec 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment