New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error-handling when pytables not installed #1306

Closed
arokem opened this Issue Jul 20, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@arokem
Member

arokem commented Jul 20, 2017

I think I missed a bug in my review of #1241

If you don't have pytables installed, then this line will evaluate to False:

https://github.com/nipy/dipy/blob/master/dipy/io/peaks.py#L19

which means that when you reach this line:
https://github.com/nipy/dipy/blob/master/dipy/io/peaks.py#L37

There will be no variable TABLES_LESS_3_0 in your namespace, resulting in a cryptic NameError

@skoudoro

This comment has been minimized.

Member

skoudoro commented Jul 20, 2017

Right, I take this one ! Unfortunately, I can not do it now so I will create a PR at the end of the week.

@arokem

This comment has been minimized.

Member

arokem commented Jul 20, 2017

Thanks!

@aarya22

This comment has been minimized.

Contributor

aarya22 commented Jul 21, 2017

@skoudoro It would also be more helpful to edit cryptic NameError message to ask the user to check if they have pyTables installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment