New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate dipy.io.trackvis? #1339

Closed
arokem opened this Issue Sep 21, 2017 · 7 comments

Comments

Projects
4 participants
@arokem
Member

arokem commented Sep 21, 2017

At the very least, we need to update this line in the documentation: https://github.com/nipy/dipy/blob/master/dipy/io/trackvis.py#L10

See for example conversation here: https://mail.python.org/pipermail/neuroimaging/2017-September/001525.html

An easy fix for now would be to replace that function with a call out to nibabel and a deprecation warning.

@skoudoro

This comment has been minimized.

Member

skoudoro commented Sep 21, 2017

I see an opportunity for me to learn and migrate DIPY to the new streamlines API. I will create a new PR and work on it next week

@arokem

This comment has been minimized.

Member

arokem commented Sep 21, 2017

@jchoude

This comment has been minimized.

Contributor

jchoude commented Oct 4, 2017

I fully support deprecating the old code. +1 from me.

@matthew-brett

This comment has been minimized.

Member

matthew-brett commented Oct 4, 2017

As the author of the old code - fine with me too.

@skoudoro skoudoro added this to Issues without PR in Dipy 0.14.0 Nov 8, 2017

@arokem

This comment has been minimized.

Member

arokem commented Nov 18, 2017

Hey @skoudoro : have you had a chance to look into this?

@skoudoro

This comment has been minimized.

Member

skoudoro commented Nov 20, 2017

yes @arokem, I started to look at this and I have a local PR. Maybe, I should push it with a WIP tag.

@arokem

This comment has been minimized.

Member

arokem commented Nov 21, 2017

@skoudoro skoudoro moved this from Issues without PR to WIP in Dipy 0.14.0 Dec 1, 2017

@skoudoro skoudoro moved this from WIP to Issues without PR in Dipy 0.14.0 Dec 1, 2017

@skoudoro skoudoro moved this from Issues without PR to WIP in Dipy 0.14.0 Feb 5, 2018

Dipy 0.14.0 automation moved this from WIP to Done Mar 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment