New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test broken in numpy 1.14 #1346

Closed
skoudoro opened this Issue Oct 3, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@skoudoro
Member

skoudoro commented Oct 3, 2017

As we can see on recent PR like here, all basic test seems to be broken.

All numpy arrays seem to be different after 10-12 decimal. I am surprised to see this problem for such basic function like vec_norm. This behavior is really weird

Unfortunately, I can not reproduce the problem on window 10, python=3.6, numpy=1.14.0.dev0+2995e6a
When I will find a time, I will try with my mac.

Do someone have any suggestions for the good way to solve this problem? @Garyfallidis @arokem @matthew-brett @anyoneelse

@skoudoro

This comment has been minimized.

Member

skoudoro commented Oct 5, 2017

ok, I was totally wrong, all errors come from DOCTEST and I can reproduce them.

When we print the result, it seems there is a space after each first element in an array and it was not the case before.

@matthew-brett

This comment has been minimized.

Member

matthew-brett commented Oct 5, 2017

Is this the change to doctest printing in the numpy development version - that arrived here : numpy/numpy@710e032 ?

If so, I think you can fix it with a call to np.set_printoptions(sign='legacy') - see nipy/nibabel#556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment