New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickbundles tutorials miss reference #1371

Closed
Garyfallidis opened this Issue Oct 27, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@Garyfallidis
Member

Garyfallidis commented Oct 27, 2017

Some of the segmentation tutorials using QuickBundles do not have a reference to the original QuickBundles paper.

@jhlegarreta

This comment has been minimized.

Contributor

jhlegarreta commented Feb 14, 2018

@Garyfallidis @skoudoro I had a look at this, but everything seems to be in place in the code:
doc/examples/segment_quickbundles.py contains a reference to the (original?) paper.

It is also visible on the website.

It's also in the python class containing the method implementation and the segmentation metrics as well.

Now it's true that Enhancing QuickBundles with different metrics and features does not cross-ref it.

So I'm wondering if that is not the intended reference (present in cite.rst also), or else, it is missing from somewhere else that I did not spot. I'd be happy to fix this.

@skoudoro

This comment has been minimized.

Member

skoudoro commented Feb 14, 2018

All the QuickBundles tutorials should have a reference to the original paper.

@jhlegarreta

This comment has been minimized.

Contributor

jhlegarreta commented Feb 14, 2018

@skoudoro thanks. OK, I'll submit a patch set having this in mind.

jhlegarreta pushed a commit to jhlegarreta/dipy that referenced this issue Feb 19, 2018

Jon Haitz Legarreta Gorroño
DOC: Fix missing reference to QuickBundles paper.
Fix missing reference to QuickBbundles paper in the "Enhancing
QuickBundles with different metrics and features" example:
http://nipy.org/dipy/examples_built/segment_extending_clustering_framework.html#example-segment-extending-clustering-framework

Fixes nipy#1371.

jhlegarreta pushed a commit to jhlegarreta/dipy that referenced this issue Mar 5, 2018

Jon Haitz Legarreta Gorroño
DOC: Fix missing reference to QuickBundles paper.
Fix missing reference to QuickBbundles paper in the "Enhancing
QuickBundles with different metrics and features" example:
http://nipy.org/dipy/examples_built/segment_extending_clustering_framework.html#example-segment-extending-clustering-framework

Fixes nipy#1371.

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this issue Sep 20, 2018

Jon Haitz Legarreta Gorroño
DOC: Fix missing reference to QuickBundles paper.
Fix missing reference to QuickBbundles paper in the "Enhancing
QuickBundles with different metrics and features" example:
http://nipy.org/dipy/examples_built/segment_extending_clustering_framework.html#example-segment-extending-clustering-framework

Fixes nipy#1371.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment