New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning in newer versions of scipy, because `scipy.misc` is going away #1394

Closed
arokem opened this Issue Jan 1, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@arokem
Member

arokem commented Jan 1, 2018

Warnings of this sort:

/home/travis/build/arokem/dipy/venv/lib/python3.5/site-packages/dipy/reconst/tests/test_mapmri.py:29: DeprecationWarning: `factorial` is deprecated!
Importing `factorial` from scipy.misc is deprecated in scipy 1.0.0. Use `scipy.special.factorial` instead.
  f = np.sqrt(2) * factorial(n) / float(((gamma(1 + n / 2.0)) *

Should be an easy fix to introduce a conditional import wherever we are importing factorial

@skoudoro

This comment has been minimized.

Member

skoudoro commented Jan 1, 2018

there is already a PR : #1326. Can you update this PR @jhlegarreta and we merge it ?

Thanks !

@skoudoro

This comment has been minimized.

Member

skoudoro commented Jan 15, 2018

done by PR #1326 merged so I close this one

@skoudoro skoudoro closed this Jan 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment