New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window.record() resolution limit #1420

Closed
dmreagan opened this Issue Feb 9, 2018 · 8 comments

Comments

Projects
5 participants
@dmreagan
Copy link
Contributor

dmreagan commented Feb 9, 2018

Description

window.record() can be used to save a render to a PNG image. If you set the size to be higher than your monitor size, the resulting image will be capped to just under your monitor's resolution. For example, if you set size=(5000, 5000), but your monitor's resolution is (1920, 1080), the image width will end up being something like 1916 pixels.

Way to reproduce

Run any viz example that saves a render with window.record(), but change the size to be very high. Tested on Windows and Mac with VTK 7.

@dmreagan dmreagan added this to Issues in Viz Module Feb 9, 2018

@ShreyasFadnavis

This comment has been minimized.

Copy link
Contributor

ShreyasFadnavis commented Mar 12, 2018

Can you review my pull request for this? #1453

@dmreagan

This comment has been minimized.

Copy link
Contributor

dmreagan commented Mar 13, 2018

@ShreyasFadnavis and @karandeepSJ report that they had no trouble with large resolutions on their systems. Can you both report which OS, Python, and VTK versions you are using to get these successful results?

@ShreyasFadnavis

This comment has been minimized.

Copy link
Contributor

ShreyasFadnavis commented Mar 13, 2018

@dmreagan I tested this on both Windows 10 and Ubuntu 16.04.
Python Version: 3.6.4
VTK Version: 7.1.1

@karandeepSJ

This comment has been minimized.

Copy link
Contributor

karandeepSJ commented Mar 13, 2018

Ubuntu 16.04
Python Version: 3.5.2
VTK Version: 8.1.0

@skoudoro

This comment has been minimized.

@thechargedneutron

This comment has been minimized.

Copy link
Contributor

thechargedneutron commented May 4, 2018

@dmreagan Is this issue on Ubuntu as well? Upon changing the size to (6000, 6000) I got a file with a size of (6000, 6000).

@thechargedneutron

This comment has been minimized.

Copy link
Contributor

thechargedneutron commented May 4, 2018

@skoudoro very nicely figured the problem. @dmreagan I have added a patch in my branch here. Can you please verify if this is working fine since this issue is not there on Ubuntu I guess.

@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented Sep 20, 2018

This issue was moved to fury-gl/fury#13

@skoudoro skoudoro closed this Sep 20, 2018

@skoudoro skoudoro moved this from Issues to Done in Viz Module Oct 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment