New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scipy stopped supporting scipy.misc.imread #1519

Closed
Garyfallidis opened this Issue May 14, 2018 · 6 comments

Comments

Projects
None yet
4 participants
@Garyfallidis
Copy link
Member

Garyfallidis commented May 14, 2018

With the latest scipy version

from scipy.misc import imread

is not available anymore.

In their website they suggest using

from imageio import imread

However vtk does provide some png readers too. A note here that we were using imread only in dipy.viz. We need to decide for a replacement asap. This change will affect any DIPY users who try to use DIPY's visualization with latest scipy version.

@arokem

This comment has been minimized.

Copy link
Member

arokem commented May 21, 2018

IIUC, this is the only place that we use this function:

https://github.com/nipy/dipy/blob/master/dipy/viz/window.py#L898

Is that correct?

Could we use the skimage equivalent?

http://scikit-image.org/docs/dev/api/skimage.io.html#skimage.io.imread

I think that it's already a dependency for the otsu segmentation, right? If not, I wouldn't mind adding it as a dependency.

@Garyfallidis

This comment has been minimized.

Copy link
Member

Garyfallidis commented May 21, 2018

I have a fix for this in PR #1528
VTK provides readers for PNG files. No need for other dependencies.

@arokem

This comment has been minimized.

Copy link
Member

arokem commented May 21, 2018

Yeah - looks great. I guess we can close this when that PR is in.

@Garyfallidis

This comment has been minimized.

Copy link
Member

Garyfallidis commented May 21, 2018

Yep, yep!

@Garyfallidis

This comment has been minimized.

Copy link
Member

Garyfallidis commented May 21, 2018

:)

@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented Sep 13, 2018

fix by #1528, closing

@skoudoro skoudoro closed this Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment