New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SF threshold in PMF is not relative #1582

Closed
frheault opened this Issue Jul 5, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@frheault
Copy link

frheault commented Jul 5, 2018

When using the LocalTracking a ProbabilisticDirectionGetter needs to be provided, ProbabilisticDirectionGetter requires a relative_peak_threshold. Which is supposed to ensure that a linear scaling of FODf amplitude does not affect the tracking.

Example:
Same datasets, artificially scaled FODf (factor 0.1, 1, 10) should produced identical tracking. This is not the case. The results are that tracking using the factor 0.1 results in 0 streamlines and a large difference is observable between the local tracking using the factor 1 and the factor 10.

https://drive.google.com/open?id=1j-V6xx4Y18e1B_LsKgdGT0t8qdUYkVCz
@gabknight is the sfthreshold aimed to cover this situation ?

@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented Aug 22, 2018

fix by #1583, closing

@skoudoro skoudoro closed this Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment