Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could tests for functionality not supported on big endians just skip? #1587

Closed
yarikoptic opened this issue Jul 12, 2018 · 7 comments · Fixed by #1903

Comments

@yarikoptic
Copy link
Member

commented Jul 12, 2018

Description

in debian on s390x we have a number of tests failing thus failing the entire build process:
https://buildd.debian.org/status/fetch.php?pkg=dipy&arch=s390x&ver=0.14.0-1&stamp=1526401155&raw=0
I wondered if you could

  1. Move from ValueError to some dedicated ArchitectureNotSupportedError derived from NotImplementedError exception?
  2. decorate such tests (or may be possible to adjust general runner?) so they would catch such exception and skip the test?

Cheers!

@arokem

This comment has been minimized.

Copy link
Member

commented Jul 12, 2018

I don't have any objections to this. The decorator approach sounds the most straight-forward. Since it sounds like you have some specific implementation details in mind, would you mind putting in a PR for that?

@yarikoptic

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2018

oh, I also didn't realize that it was the exception stemming all the way from Cython... will look in there too, and meanwhile will propose a PR here as well... hopefully ;-)

@emanuele

This comment has been minimized.

Copy link
Contributor

commented Feb 5, 2019

Hi,

Even though I haven't contributed to the solution of this issue, I'd like to remind everyone that Python2 will retire in 10 months and, at the moment, this issue is preventing DiPy to have a Python3 package in NeuroDebian. As far as I understand NeuroDebian is one of the main ways to distribute DiPy so many users will get in trouble before the end of this year.

If some of you has time and knowledge to fix this issue, it will be greatly appreciated.

@arokem

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

Hey @yarikoptic : sorry for the slowness here. Do you have any idea: how would we know that we are on a s390x machine? Is there something in the os module that can tell us that?

@yarikoptic

This comment has been minimized.

Copy link
Member Author

commented Jul 16, 2019

I guess what matters is the endianness -- sys.byteorder to consult

yoh@zelenka:~$ uname -a
Linux zelenka 4.9.0-9-s390x #1 SMP Debian 4.9.168-1+deb9u3 (2019-06-16) s390x GNU/Linux

yoh@zelenka:~$ python -c 'import sys; print(sys.byteorder)'
big
@arokem

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

Thanks @yarikoptic!

@skoudoro : are you on it?

@skoudoro

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

ok, on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.