New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viz.ui.FileMenu2D #1618

Closed
MarcCote opened this Issue Aug 15, 2018 · 1 comment

Comments

Projects
2 participants
@MarcCote
Copy link
Contributor

MarcCote commented Aug 15, 2018

Description

The FileMenu2D class, introduced in #1592, could be refactored to avoid reimplementing scrolling and selection logic that are already done in ListBox2D component. Also, the scroll_callback is responsible for updating the colors of the text in the slots which seems weird. It would be better if the scroll only tells which slots should be displayed on the screen, then let the slots decides how to render themselves.

Related comments

#1570 (comment)
#1570 (comment)

@dmreagan dmreagan added this to PR needs a review in Viz Module Aug 21, 2018

@dmreagan dmreagan moved this from PR needs a review to Issues in Viz Module Aug 22, 2018

@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented Sep 20, 2018

This issue was moved to fury-gl/fury#16

@skoudoro skoudoro closed this Sep 20, 2018

@skoudoro skoudoro moved this from Issues to Done in Viz Module Oct 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment