New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure in FORECAST #1654

Closed
arokem opened this Issue Oct 17, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@arokem
Copy link
Member

arokem commented Oct 17, 2018

Folllowing up from #1624.

On current master:

dipy (master)$nosetests dipy/reconst/tests/test_forecast.py 
F.....
======================================================================
FAIL: dipy.reconst.tests.test_forecast.test_forecast_positive_constrain
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/arokem/.virtualenvs/dipy/lib/python3.7/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/Users/arokem/.virtualenvs/dipy/lib/python3.7/site-packages/numpy/testing/_private/decorators.py", line 155, in skipper_func
    return f(*args, **kwargs)
  File "/Users/arokem/source/dipy/dipy/reconst/tests/test_forecast.py", line 53, in test_forecast_positive_constrain
    assert_almost_equal(fodf[fodf < 0].sum(), 0, 2)
  File "/Users/arokem/.virtualenvs/dipy/lib/python3.7/site-packages/numpy/testing/_private/utils.py", line 584, in assert_almost_equal
    raise AssertionError(_build_err_msg())
AssertionError: 
Arrays are not almost equal to 2 decimals
 ACTUAL: -0.015931951384411995
 DESIRED: 0

----------------------------------------------------------------------
Ran 6 tests in 0.264s

Looking closer, it looks like indeed the positivity constraint is no longer applied to the fodf. That is, there are negative components in the fodf.

My guess is that this has to do with the (very) recent version of cvxpy that was just released today. My hunch is that this is a bug in the way the positivity constraints are implemented in this new version of cvxpy, rather than a change in API. It would be good to come up with a minimal example that we could report to them.

@skoudoro

This comment has been minimized.

Copy link
Member

skoudoro commented Oct 17, 2018

Can you have a look at this issue cvxgrp/cvxpy#591 @arokem? It seems related to our problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment