Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale values in `decfa` #1751

Closed
arokem opened this issue Mar 5, 2019 · 0 comments

Comments

@arokem
Copy link
Member

commented Mar 5, 2019

Description

The function dipy.io.utils.decfa currently expects as input a color FA image that has been scaled, so that it can be cast into the uint8-based dtype that is used in the function itself.

If users provide the output of our color FA function, the result is most likely to be a volume full of (0, 0, 0) tuples, which is useless.

We need to either document this behavior or (maybe even better?) scale the data within the function.

@skoudoro skoudoro closed this in d6d4bf8 Mar 7, 2019

skoudoro added a commit that referenced this issue Mar 7, 2019
Merge pull request #1753 from arokem/fix-1751
BF: Fixes #1751, by adding a `scale` key-word arg to `decfa`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.