Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Threshold default in QballBaseModel #1763
Is there a reason that
The data I am working are scaled between [0, 1], so using the default parameters when reconstructing with
I had to dig around a lot to find the source of the problem, I think setting a new default could save others some time, unless there is a specific reason it is set so high.
actually, I misspoke, the raw data is 16-bit uints. The normalization to [-1.12,1.12] happened sometime during denoising, registration, etc.
Either way: I still think setting the threshold default lower might be a good idea, I can imagine others might have the same problem in the future.
Looking at the code a bit more, I see that
so the default is to clip to [1,1], which should probably also change.