New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension test in dipy_fit_tensor seems brittle #177

Closed
matthew-brett opened this Issue Apr 16, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@matthew-brett
Member

matthew-brett commented Apr 16, 2013

Around line 46, we break the filename into the part before and after the first '.' I think this is for images, in order to get "filename" from "filename.nii.gz". But the filename could have another dot in it, and that would cause a mess. Maybe this could be better done by a little function that splits off known compression extensions like 'gz' and 'bz2' and then splits off the remaining extension?

It would be really good to have some tests for this script - they could go in dipy/tests/test_scripts.py

@arokem

This comment has been minimized.

Member

arokem commented Jan 11, 2014

This is closed through #190

@arokem arokem closed this Jan 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment