New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPT: Change dipy.core.sphere_stats.random_uniform_on_sphere #181

Closed
ecaruyer opened this Issue May 14, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@ecaruyer
Contributor

ecaruyer commented May 14, 2013

The function dipy.core.sphere_stats.random_uniform_on_sphere currently generates a random vector in R^3 following a normal distribution, then normalizes it. This obviously works well and is correct mathematically. It is however somehow difficult to read (at least for me) and slightly suboptmial. So why not use one of the methods described here: http://mathworld.wolfram.com/SpherePointPicking.html?

@ghost ghost assigned ecaruyer May 14, 2013

MrBago pushed a commit that referenced this issue May 28, 2013

MrBago
Merge pull request #183 from ecaruyer/fix-for-issue-181
OPT: Modified dipy.core.sphere_stats.random_uniform_on_sphere, cf issue #181
@arokem

This comment has been minimized.

Member

arokem commented Jan 11, 2014

I believe this is resolved through #183

@arokem arokem closed this Jan 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment