Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IVIM VarPro implementation throws infeasible 'x0' #1828

Closed
ShreyasFadnavis opened this issue May 7, 2019 · 2 comments

Comments

@ShreyasFadnavis
Copy link
Member

commented May 7, 2019

Description

This bug occurs rarely when the number of iterations for Differential Evolution is low.

Will follow-up with a PR with:

  • Default
  • Warning when user reduces the maxiter below a certain value.

#1826 will also help fix some of these issues.

Way to reproduce

-- Cannot be reproduced with a fixed recipe.

@ShreyasFadnavis

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

@Garyfallidis @arokem Please feel free to let me know any other approach you have in mind. Another alternative I have is to switch to LM implementation is the solution is infeasible (may result in a linear fit though). I think, after Cythonizing the implementation, this bug would go away anyways!

@ShreyasFadnavis ShreyasFadnavis self-assigned this May 8, 2019

@ShreyasFadnavis ShreyasFadnavis added this to the 1.0 milestone May 8, 2019

@ShreyasFadnavis ShreyasFadnavis changed the title Bug: IVIM VarPro implementation throws infeasible 'x0' ENH: IVIM VarPro implementation throws infeasible 'x0' May 8, 2019

@ShreyasFadnavis ShreyasFadnavis changed the title ENH: IVIM VarPro implementation throws infeasible 'x0' IVIM VarPro implementation throws infeasible 'x0' May 8, 2019

@ShreyasFadnavis ShreyasFadnavis referenced this issue May 20, 2019
0 of 1 task complete
@ShreyasFadnavis

This comment has been minimized.

Copy link
Member Author

commented May 20, 2019

#1839 fixes this. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.