Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`segment.bundles` package not being tested #1889

Closed
jhlegarreta opened this issue Jul 5, 2019 · 2 comments

Comments

@jhlegarreta
Copy link
Contributor

commented Jul 5, 2019

Description

The bundles package's unit test is empty.

The test file's history shows that there has been some refactoring at some point, but it looks like some testing code was either misplaced or the test_bundles.py needs to be fed with the appropriate testing code.

codecov reports a 91.47% coverage for that package, but it may well be because it is being called as an intermediate step from other tests or code fragments.

@arokem

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Looks like prior to this commit there wasn't a test file for this module. Then, I moved the tests that I had created in this commit.

Maybe we should simply remove this file altogether? Looks like most of that stuff is tested in test_rb.py. Another option would be to rename that to test_bundles.py for clarity. WDYT @Garyfallidis?

@skoudoro

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

fixed by #1891, closing

@skoudoro skoudoro closed this Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.