Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better warning when dipy is installed without fury #1976

Closed
arokem opened this issue Oct 2, 2019 · 1 comment
Closed

Better warning when dipy is installed without fury #1976

arokem opened this issue Oct 2, 2019 · 1 comment
Milestone

Comments

@arokem
Copy link
Contributor

arokem commented Oct 2, 2019

Description

If dipy is installed without fury, and the following line (from our examples) is run:

from dipy.viz import actor, window, ui

the user will likely see an uninformative error:

---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-1-5eadb5980917> in <module>
----> 1 from dipy.viz import actor, window, ui

ImportError: cannot import name 'actor' from 'dipy.viz' (/Users/arokem/.virtualenvs/test_dipy_no_fury/lib/python3.7/site-packages/dipy/viz/__init__.py)`

This is because the current implementation of optional_pkg doesn't handle from foo import bar imports elegantly.

I think that we should provide more useful information here

@skoudoro
Copy link
Member

Fixed by #1977 , closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants