New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ndindex to peaks_from_model #220

Closed
samuelstjean opened this Issue Jul 26, 2013 · 3 comments

Comments

Projects
None yet
3 participants
@samuelstjean
Contributor

samuelstjean commented Jul 26, 2013

Currently, it kinda ravel the 3D volume, use enum on the raveled array and reshape everything at the end. Could probably be made faster by using ndindex on the 3D array and keeping as-is the 4th dimension instead.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Jul 26, 2013

Yes, good idea. Can you make a PR with this? But first please time the before and after results?

@samuelstjean

This comment has been minimized.

Contributor

samuelstjean commented Jul 26, 2013

I'll probably leave that for another code wednesday it works so far so it's a nice enhancement to have, but not critically required in my opinion.

@arokem

This comment has been minimized.

Member

arokem commented Jan 11, 2014

I believe this is closed through #221

@arokem arokem closed this Jan 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment