New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildbot error in mask.py #228

Closed
matthew-brett opened this Issue Aug 9, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@matthew-brett
Member

matthew-brett commented Aug 9, 2013

See http://nipy.bic.berkeley.edu/builders/dipy-py2.6-osx-10.5-ppc/builds/195/steps/shell_5/logs/stdio

======================================================================
ERROR: dipy.segment.tests.test_mask.test_mask
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/buildslave/osx-10.5-ppc/dipy-py2_6-osx-10_5-ppc/build/venv/lib/python2.6/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
File "/Users/buildslave/osx-10.5-ppc/dipy-py2_6-osx-10_5-ppc/build/venv/lib/python2.6/site-packages/dipy/segment/tests/test_mask.py", line 40, in test_mask
    median_test = multi_median(median_test, medianradius, 3)
File "/Users/buildslave/osx-10.5-ppc/dipy-py2_6-osx-10_5-ppc/build/venv/lib/python2.6/site-packages/dipy/segment/mask.py", line 28, in multi_median
    outvol = np.zeros_like(input, dtype=input.dtype)
TypeError: zeros_like() got an unexpected keyword argument 'dtype'

----------------------------------------------------------------------
Ran 254 tests in 163.926s

This is with numpy 1.4.1. I think that zeros_like already uses the input data type, so the extra dtype=input.dtype is not necessary. Maybe you could remove that in mask.py? The tests still pass if you do.

@arokem

This comment has been minimized.

Member

arokem commented Aug 9, 2013

Yup. #229

matthew-brett added a commit that referenced this issue Aug 16, 2013

Merge pull request #229 from arokem/zeros_like_dtype
BF: input.dtype is used per default

And no dtype kwarg on some versions of numpy.

Addresses #228
@matthew-brett

This comment has been minimized.

Member

matthew-brett commented Oct 16, 2013

Closed by pull request #229

@arokem arokem closed this Jan 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment