New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fvtk documentation is incomprehensible #282

Closed
stefanv opened this Issue Dec 10, 2013 · 6 comments

Comments

Projects
None yet
3 participants
@stefanv
Contributor

stefanv commented Dec 10, 2013

Example:

    cam_pos : None or sequence (3,), optional
        camera position
    cam_focal : None or sequence (3,), optional
        camera focal point
    cam_view : None or sequence (3,), optional
        camera view up
@arokem

This comment has been minimized.

Member

arokem commented Dec 10, 2013

Yeah - I had struggled with that camera thing too. I am not sure it works
as advertised...

On Mon, Dec 9, 2013 at 5:02 PM, Stefan van der Walt <
notifications@github.com> wrote:

Example:

cam_pos : None or sequence (3,), optional
    camera position
cam_focal : None or sequence (3,), optional
    camera focal point
cam_view : None or sequence (3,), optional
    camera view up


Reply to this email directly or view it on GitHubhttps://github.com//issues/282
.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Dec 10, 2013

Okay, I can make that docstring better. But one way to know what you are doing with the camera is to throw a fvtk.axes() actor so that you know where is your origin and your coordinate system.Then it is relatively easy to setup your camera correctly. But, yeah the fvtk module in general needs some work. We should get something better rolling for release 0.8. @stefanv feel free to correct the docstring in a new PR as you suggest in this issue. Thx!

@stefanv

This comment has been minimized.

Contributor

stefanv commented Dec 10, 2013

I don't know what "view up" means. It may be more intuitive to specify elevation and azimuth?

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Dec 10, 2013

Nope, it is very specific. It means the view up vector of the camera. Check this out. http://i.stack.imgur.com/vtkKX.png

@stefanv

This comment has been minimized.

Contributor

stefanv commented Dec 10, 2013

That would have helped a lot :)

@arokem

This comment has been minimized.

Member

arokem commented Jan 11, 2014

This will probably be addressed in #286

@arokem arokem closed this Jan 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment