New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dipy.tracking.utils.target affine parameter is misleading #351

Closed
jchoude opened this Issue Apr 23, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@jchoude
Contributor

jchoude commented Apr 23, 2014

The prototype of the "target" function specifies affine=None, so we can skip giving the affine transform. However, not giving it causes a problem when the "target" function calls _mapping_to_voxel, because that function expects either a defined affine or a defined voxel_size. Since both of them are set to None in that specific use case, the function will fail.

Target should either make it mandatory to send an affine (be it the identity matrix), or give _mapping_to_voxel the identity matrix, or have a way to specify the voxel_size parameter.

@jchoude

This comment has been minimized.

Contributor

jchoude commented Aug 8, 2016

I think this can be closed, except if @MrBago has something else to had? It was merged in pr #352

@arokem

This comment has been minimized.

Member

arokem commented Aug 10, 2016

Yup. Let's close this (reopen if needed).

@arokem arokem closed this Aug 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment