New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peak directiions test error on PPC #375

Closed
matthew-brett opened this Issue Jun 3, 2014 · 4 comments

Comments

Projects
None yet
2 participants
@matthew-brett
Member

matthew-brett commented Jun 3, 2014

There is a test error on the PPC buildbot:

http://nipy.bic.berkeley.edu/builders/dipy-py2.6-osx-10.5-ppc/builds/293/steps/shell_8/logs/stdio

======================================================================
FAIL: dipy.reconst.tests.test_peaks.test_peak_directions_thorough
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/buildslave/.local/lib/python2.6/site-packages/nose-1.1.2-py2.6.egg/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/Users/buildslave/osx-10.5-ppc/dipy-py2_6-osx-10_5-ppc/build/venv/lib/python2.6/site-packages/dipy/reconst/tests/test_peaks.py", line 222, in test_peak_directions_thorough
    assert_equal(AE < 2., True)
AssertionError: False != True

I had a look at the value for AE - it was 179.XXX (a floating point value, can't remember the values after the floating point. It seems very far off. Any thoughts? I can give a login to anyone who wants to debug.

@skoudoro

This comment has been minimized.

Member

skoudoro commented Jul 31, 2017

This build is not anymore active, closing

@skoudoro skoudoro closed this Jul 31, 2017

@matthew-brett matthew-brett reopened this Aug 1, 2017

@matthew-brett

This comment has been minimized.

Member

matthew-brett commented Aug 1, 2017

The point is not the PPC platform specifically, but understanding the error so we be confident that Dipy will work on less common platforms. Virtually none of the the bugs revealed by the PPC build are PPC-specific, but point to big-endian issues or bugs in the C code exposed by compilation non-Intel compiler.

@skoudoro

This comment has been minimized.

Member

skoudoro commented Aug 1, 2017

Ok, I see. Thanks for this information.

can you make the debian ppc build work to see if it is the only failing test. it might help to understand what happens.

Thank you

@matthew-brett

This comment has been minimized.

Member

matthew-brett commented Aug 5, 2017

Ah - sorry - I wasn't paying attention. No, that build isn't active any more - it was building on PPC OSX 10.5, but the machine is now running Debian - the builds you're pointing to above. That doesn't have the test failure at the moment:

http://nipy.bic.berkeley.edu/builders/dipy-py2.7-debian-ppc/builds/246

  • so yes, good to close.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment