Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc won't build without cvxopt #436

Closed
samuelstjean opened this issue Oct 7, 2014 · 4 comments · Fixed by #1813

Comments

@samuelstjean
Copy link
Contributor

commented Oct 7, 2014

As an optional dependency, the doc refuses to build if you don't have it installed with an import error. There should be a check in the doc build system to not build that part if the user does not have it, as it won't let you build the rest of the doc and just crash.

@arokem

This comment has been minimized.

Copy link
Member

commented Oct 7, 2014

Does this come from one of the examples? SHORE?

@samuelstjean

This comment has been minimized.

Copy link
Contributor Author

commented Oct 7, 2014

Probably, I used make html. Since it also builds the example, that would make sense. I don't have the particular line anymore since I just installed cvxopt to make them work though.

@Garyfallidis

This comment has been minimized.

Copy link
Member

commented Oct 7, 2014

Yeah this is from the SHORE example.

On Tue, Oct 7, 2014 at 10:57 AM, Samuel St-Jean notifications@github.com
wrote:

Probably, I used make html. Since it also builds the example, that would
make sense. I don't have the particular line anymore since I just installed
cvxopt to make them work though.


Reply to this email directly or view it on GitHub
#436 (comment).

@arokem

This comment has been minimized.

Copy link
Member

commented Oct 7, 2014

It is often the case that doc build have more requirements than running the
software (e.g. it requires sphinx, which is also not a strict
dependency...). I don't think that we should worry about this one too much.
Do we list the doc build dependencies somewhere? We could add that there.

On Tue, Oct 7, 2014 at 8:00 AM, Eleftherios Garyfallidis <
notifications@github.com> wrote:

Yeah this is from the SHORE example.

On Tue, Oct 7, 2014 at 10:57 AM, Samuel St-Jean notifications@github.com

wrote:

Probably, I used make html. Since it also builds the example, that would
make sense. I don't have the particular line anymore since I just
installed
cvxopt to make them work though.


Reply to this email directly or view it on GitHub
#436 (comment).


Reply to this email directly or view it on GitHub
#436 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.