New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find if replacing matrix44 from streamlinear with compose_matrix from dipy.core.geometry is a good idea #450

Closed
Garyfallidis opened this Issue Oct 26, 2014 · 1 comment

Comments

Projects
None yet
1 participant
@Garyfallidis
Member

Garyfallidis commented Oct 26, 2014

I mean to identify the differences and see if I can replace matrix44 with the one in compose_matrix.
Some care needs to be taken especially with angles and shears during the optimization process. Need to think of a good test for that. Maybe the test should be offline looking at many bundles and comparing the result both with fopt and maximum number of iterations.

@Garyfallidis Garyfallidis self-assigned this Oct 26, 2014

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Oct 30, 2014

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment