New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning for DTI normalization #451

Closed
rutgerfick opened this Issue Oct 27, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@rutgerfick
Contributor

rutgerfick commented Oct 27, 2014

The static 'min_signal' option set to 1 in the DTI fitting causes an error for normalized data.
As in normalized data there is only data between 0 and 1, the min_signal threshold sets everything to 1, giving a constant signal.

It would be a good idea to put a warning here that checks if the data is normalized. Otherwise people might be confused as to why all their eigenvalues are constant, while it is actually a setting in the fitting process that causes this.

@arokem

This comment has been minimized.

Member

arokem commented Oct 29, 2014

Thanks for the suggestion - I've run into this problem myself too in some simulations I was doing. I took a look around the code and I don't think that it would be too hard to implement. You'll need to set a default min_signal value upfront for the TensorModel class, and then check the data when it enters the fit method.

Another option is to change the min_signal to something much smaller than 1. Say 0.0001. Might still work OK, no?

@arokem

This comment has been minimized.

Member

arokem commented Nov 7, 2014

closed through #447

@arokem arokem closed this Nov 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment