Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a cython style guide #583

Closed
arokem opened this issue Mar 2, 2015 · 5 comments

Comments

@arokem
Copy link
Member

commented Mar 2, 2015

As proposed by @matthew-brett here:

#533 (comment)

@Garyfallidis

This comment has been minimized.

Copy link
Member

commented Mar 2, 2015

What about this? Pep8 everywhere except from the limitation for the length of lines.
Which is now recommendation only. With nested for loops the length restriction becomes difficult to sustain.

@matthew-brett

This comment has been minimized.

Copy link
Member

commented Mar 2, 2015

I was thinking more in terms of things like:

cimport numpy as cnp
import numpy a np

Use of npy_intp for anything holding an index or shape value, when to use the ndarray Cython syntax compared to the memoryviews compared to simple C arrays, how to use nogil to root out Python-side stuff and optimize speed, that kind of thing.

@arokem

This comment has been minimized.

Copy link
Member Author

commented Mar 2, 2015

I, for one, could use all the help I could get on how to write cython code.

@matthew-brett - do you think you could draft up something as a PR?

On Sun, Mar 1, 2015 at 8:29 PM, Matthew Brett notifications@github.com
wrote:

I was thinking more in terms of things like:

cimport numpy as cnp
import numpy a np

Use of npy_intp for anything holding an index or shape value, when to use
the ndarray Cython syntax compared to the memoryviews compared to simple C
arrays, how to use nogil to root out Python-side stuff and optimize speed,
that kind of thing.


Reply to this email directly or view it on GitHub
#583 (comment).

jhlegarreta added a commit to jhlegarreta/dipy that referenced this issue Jan 4, 2019
DOC: Add Cython style guideline for DIPY.
Add Cython style guideline for DIPY.

Fixes nipy#583.
jhlegarreta added a commit to jhlegarreta/dipy that referenced this issue Jan 4, 2019
DOC: Add Cython style guideline for DIPY.
Add Cython style guideline for DIPY.

Fixes nipy#583.
jhlegarreta added a commit to jhlegarreta/dipy that referenced this issue Jan 27, 2019
DOC: Add Cython style guideline for DIPY.
Add Cython style guideline for DIPY.

Fixes nipy#583.
jhlegarreta added a commit to jhlegarreta/dipy that referenced this issue Feb 2, 2019
DOC: Add Cython style guideline for DIPY.
Add Cython style guideline for DIPY.

Fixes nipy#583.
jhlegarreta added a commit to jhlegarreta/dipy that referenced this issue Feb 7, 2019
DOC: Add Cython style guideline for DIPY.
Add Cython style guideline for DIPY.

Fixes nipy#583.
jhlegarreta added a commit to jhlegarreta/dipy that referenced this issue Feb 8, 2019
DOC: Add Cython style guideline for DIPY.
Add Cython style guideline for DIPY.

Fixes nipy#583.
jhlegarreta added a commit to jhlegarreta/dipy that referenced this issue Feb 8, 2019
DOC: Add Cython style guideline for DIPY.
Add Cython style guideline for DIPY.

Fixes nipy#583.
jhlegarreta added a commit to jhlegarreta/dipy that referenced this issue Feb 8, 2019
DOC: Add Cython style guideline for DIPY.
Add Cython style guideline for DIPY.

Fixes nipy#583.
jhlegarreta added a commit to jhlegarreta/dipy that referenced this issue Mar 5, 2019
DOC: Add Cython style guideline for DIPY.
Add Cython style guideline for DIPY.

Fixes nipy#583.

@skoudoro skoudoro reopened this Mar 8, 2019

@skoudoro skoudoro added this to the 1.0 milestone Apr 23, 2019

@jhlegarreta

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

@skoudoro following what was discussed in today's dev meeting, I would close this issue. IMHO, it is unlikely that it gets more updates. We do have a minimal style guide, and it is a starting point. If at some point we find that it needs more content, we may re-open the issue then or just open a PR with the new content.

@skoudoro

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

ok, I agree, let's close it.

@skoudoro skoudoro closed this Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.