Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't TRACKPOINT be renamed to NODIRECTION? #592

Closed
Garyfallidis opened this issue Mar 14, 2015 · 3 comments

Comments

@Garyfallidis
Copy link
Member

commented Mar 14, 2015

Hi @gabknight and @MrBago,

Is the that the TRACKPOINT stopping criterion is used now only when there is no available direction. I think it would make the docs much more clear if we use NODIRECTION rather than the current name.

Cheers!

@MrBago

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2015

The tissue classifier is independent of the direction getter and cannot know whether a direction exists or not. TRACKPOINT is used when the tissue classifier believes the point should be part of a tract (and most of the time it is), but for some points that are marked as TRACKPOINT the direction getter is unable to generate a valid tracking direction.

If you point us to where you believe the docs are unclear, we can brainstorm some ways to improve them.

@Garyfallidis

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2015

Yeah, what you say here afaik doesn't come out from the current tutorials. Please add this information in tutorial doc/examples/tracking_tissue_classifier.py or in the other ones too if you think it is necessary.

@skoudoro

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

closing, fixed on #1882 by @gabknight

@skoudoro skoudoro closed this Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.