New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absolute Imports in Tracking #1009

Closed
wants to merge 9 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@theaverageguy
Contributor

theaverageguy commented Mar 23, 2016

Fixes Issue #1001

@arokem

This comment has been minimized.

Member

arokem commented Mar 23, 2016

A good way to sort out this kind of thing is to test it on your own machine before pushing. You can run the tests locally with nose.

@sahmed95

This comment has been minimized.

Contributor

sahmed95 commented Mar 27, 2016

In 927dcc6#diff-dabbfc9d5ab28faed60ef453735df58dR10

I guess you missed dipy.reconst.cache

@@ -65,7 +65,7 @@
from dipy.tracking import metrics

# Import helper functions shared with vox2track
from ._utils import (_mapping_to_voxel, _to_voxel_coordinates)
from tracking._utils import (_mapping_to_voxel, _to_voxel_coordinates)

This comment has been minimized.

@arokem

arokem Mar 28, 2016

Member

I believe this needs to be:

from dipy.tracking._utils ...
@arokem

This comment has been minimized.

Member

arokem commented Apr 13, 2016

Any chance to get this rebased on master and to make that small fix?

@sahmed95

This comment has been minimized.

Contributor

sahmed95 commented Apr 13, 2016

Could make it myself, but is there a way for two people to push commits to the same PR ? (Without making a new branch/pull request). Just out of curiosity - can multiple people work on the same PR ?

@arokem

This comment has been minimized.

Member

arokem commented Apr 13, 2016

Only if you are made a collaborator on that fork. It would probably result
in a mess, though.

You can make a PR on the fork, against this branch.

On Wed, Apr 13, 2016 at 1:21 PM, Shahnawaz Ahmed notifications@github.com
wrote:

Could make it myself, but is there a way for two people to push commits to
the same PR ? (Without making a new branch/pull request). Just out of
curiosity - can multiple people work on the same PR ?


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#1009 (comment)

@sahmed95

This comment has been minimized.

Contributor

sahmed95 commented Apr 13, 2016

Will look it up. Thanks. But I guess it will be messy.

@theaverageguy

This comment has been minimized.

Contributor

theaverageguy commented Apr 14, 2016

I have my finals going on for about two weeks. Sorry for no response. I am
fixing everything today after 4ish IST.

On Thu, Apr 14, 2016 at 1:57 AM, Shahnawaz Ahmed notifications@github.com
wrote:

Will look it up. Thanks. But I guess it will be messy.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#1009 (comment)

@arokem

This comment has been minimized.

Member

arokem commented Oct 21, 2016

This one seems abandoned. Closing, but if someone wants to pick it back up, feel free to reopen.

@arokem arokem closed this Oct 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment