New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Predict DKI with a volume of S0 #1028

Merged
merged 2 commits into from May 17, 2016

Conversation

Projects
None yet
2 participants
@arokem
Member

arokem commented Apr 14, 2016

The first commit introduces a test that demonstrates the bug: if the S0 input to DKI prediction is provided as a ndarray (which should be possible!), this raises an error.

The second commit fixes this bug, by separating into two cases: one when S0 is an ndarray (assumed to have the right shape!), and one when it is a float.

@arokem

This comment has been minimized.

Member

arokem commented Apr 14, 2016

@RafaelNH : could you please take a look? Thanks!

arokem added a commit to arokem/pyAFQ that referenced this pull request Apr 14, 2016

BF: Monkey-patch a working version of the DKI prediction.
See fix in: nipy/dipy#1028.
Should be resolved in dipy 0.12
@RafaelNH

This comment has been minimized.

Contributor

RafaelNH commented Apr 14, 2016

@arokem - excellent, well spotted! In my opinion this can be merged!

arokem added a commit to arokem/pyAFQ that referenced this pull request Apr 20, 2016

@arokem

This comment has been minimized.

Member

arokem commented May 4, 2016

Does anyone have any comments here? It's just a small bugfix!

@RafaelNH

This comment has been minimized.

Contributor

RafaelNH commented May 4, 2016

As mentioned above everything looks fine here. If there isn't any objections, I will merge this tomorrow!

@RafaelNH RafaelNH merged commit 43f9985 into nipy:master May 17, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment