New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for fetcher files in Windows #1035

Merged
merged 4 commits into from Apr 20, 2016

Conversation

Projects
None yet
3 participants
@manu-tej
Contributor

manu-tej commented Apr 18, 2016

Fix for #1030
'pathname2url' method is not needed in the test_fetcher.py

@manu-tej

This comment has been minimized.

Contributor

manu-tej commented Apr 18, 2016

I will rebase it shortly

@arokem

This comment has been minimized.

Member

arokem commented Apr 18, 2016

Great. That should also trigger a test on Travis (I just flipped the switch there back to "on").

@arokem

This comment has been minimized.

Member

arokem commented Apr 18, 2016

I can run this on our buildbots, once you rebase this. Ping me when you've done that.

@manu-tej manu-tej force-pushed the manu-tej:fetcher_fix branch from 0ba5e5f to e2b4b11 Apr 18, 2016

@manu-tej

This comment has been minimized.

Contributor

manu-tej commented Apr 18, 2016

@arokem completed rebasing

@arokem

This comment has been minimized.

Member

arokem commented Apr 19, 2016

Thank you. I've launched a test on one of the buildbots that was previously failing, from this branch here: http://nipy.bic.berkeley.edu/builders/dipy-bdist32-34/builds/249

@manu-tej

This comment has been minimized.

Contributor

manu-tej commented Apr 19, 2016

@arokem: added the required modules

@manu-tej

This comment has been minimized.

Contributor

manu-tej commented Apr 19, 2016

@arokem there is a good chance that this should fix the problem.

@arokem

This comment has been minimized.

Member

arokem commented Apr 19, 2016

OK - thanks. This is the relevant Windows build testing that:
http://nipy.bic.berkeley.edu/builders/dipy-bdist32-34/builds/251

On Tue, Apr 19, 2016 at 7:24 AM, Manu Tej Sharma notifications@github.com
wrote:

@arokem https://github.com/arokem there is a good chance that this
should fix the problem.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1035 (comment)

@manu-tej

This comment has been minimized.

Contributor

manu-tej commented Apr 19, 2016

Meanwhile I will setup my own windows machine for testing.

@manu-tej

This comment has been minimized.

Contributor

manu-tej commented Apr 19, 2016

@arokem : all the tests are passing. There are some residues which we don't need and I will remove them in next commit.
@ghoshbishakh : Can you have a look at it ? I hope I didn't break the download progress bar.

@arokem

This comment has been minimized.

Member

arokem commented Apr 19, 2016

Yeah. Looks like there might be some un-needed imports now. Otherwise, LGTM.

@ghoshbishakh

This comment has been minimized.

Member

ghoshbishakh commented Apr 20, 2016

@manu-tej changes are in the tests so progressbar should be fine! 😄 thanks!

@ghoshbishakh

This comment has been minimized.

Member

ghoshbishakh commented Apr 20, 2016

@manu-tej the 4 commits can be squashed into to 2 to make it cleaner

@arokem

This comment has been minimized.

Member

arokem commented Apr 20, 2016

No need to squash. I'll go ahead and merge.

@arokem

This comment has been minimized.

Member

arokem commented Apr 20, 2016

Thanks both!

@arokem arokem merged commit c5103fd into nipy:master Apr 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment