New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc - fix definition of real_sph_harm functions #1039

Merged
merged 1 commit into from May 14, 2016

Conversation

Projects
None yet
2 participants
@MrBago
Contributor

MrBago commented Apr 29, 2016

Can someone double check me, but I think this is right now.

$Y^m_n$ if m == 0
Imag($Y^m_n$) * sqrt(2) if m < 0
Imag($Y^m_n$) * sqrt(2) if m > 0
$Y^m_n$ if m == 0

This comment has been minimized.

@arokem

arokem Apr 30, 2016

Member

I think that's correct. I believe that we are following the same convention as the one outlined in @mdesco et al.'s 2007 paper (http://onlinelibrary.wiley.com/doi/10.1002/mrm.21277/full). See equation 3. I believe you can write this central line as:

$Y^0_n$     if m=0 

I don't think that we need to collapse the index here, as they do in that paper.

This comment has been minimized.

@MrBago

MrBago May 13, 2016

Contributor

I changed the middle line, does this look better?

@arokem

This comment has been minimized.

Member

arokem commented May 5, 2016

Any more comments here? I'll merge this in a couple of days, if I don't hear from anyone.

@MrBago MrBago force-pushed the MrBago:doc_fix_shm_basis branch from 4e04d2c to 43e55ab May 13, 2016

@arokem

This comment has been minimized.

Member

arokem commented May 14, 2016

LGTM. Merging.

@arokem arokem merged commit f983d1f into nipy:master May 14, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment