New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Added a coverage badge to README.rst #1072

Merged
merged 3 commits into from Jun 15, 2016

Conversation

Projects
None yet
3 participants
@yarikoptic
Member

yarikoptic commented Jun 6, 2016

Closes #1071

@coveralls

This comment has been minimized.

coveralls commented Jun 7, 2016

Coverage Status

Changes Unknown when pulling 5b1414c on yarikoptic:enh-coverallsbadge into * on nipy:master*.

@yarikoptic

This comment has been minimized.

Member

yarikoptic commented Jun 7, 2016

woohoo -- coverage is now reported... let me add also codecov -- once again, like that one better ;)

@coveralls

This comment has been minimized.

coveralls commented Jun 7, 2016

Coverage Status

Changes Unknown when pulling 61709ef on yarikoptic:enh-coverallsbadge into * on nipy:master*.

@arokem

This comment has been minimized.

Member

arokem commented Jun 7, 2016

In the past, we've refrained from adding these badges (#860). I don't mind adding this badge. Do I understand correctly that it's unaffected if Travis flakes out for some reason? That was the main objection to adding the badges before.

@yarikoptic

This comment has been minimized.

Member

yarikoptic commented Jun 8, 2016

not sure about travis flaking out effect... does it happen often that travis fails running tests on master?

@coveralls

This comment has been minimized.

coveralls commented Jun 8, 2016

Coverage Status

Changes Unknown when pulling b3be38e on yarikoptic:enh-coverallsbadge into * on nipy:master*.

@yarikoptic

This comment has been minimized.

Member

yarikoptic commented Jun 8, 2016

and now get codecov badge just in case ;)

@yarikoptic

This comment has been minimized.

Member

yarikoptic commented Jun 9, 2016

if still in doubt you can preview badges on https://github.com/yarikoptic/dipy/blob/b3be38e5ac73a841fa113ee51f55e29de9ee6703/README.rst
(coveralls is not reported since it requires it being merged first)

@arokem

This comment has been minimized.

Member

arokem commented Jun 15, 2016

I am +1 for adding these badges. Anyone else have any opinion?

@yarikoptic

This comment has been minimized.

Member

yarikoptic commented Jun 15, 2016

It makes two of us... the others are silent so I will use my superpowers!

@yarikoptic yarikoptic merged commit 5028690 into nipy:master Jun 15, 2016

3 checks passed

codecov/patch 100% of diff hit (target 80.79%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 82.858%
Details

@yarikoptic yarikoptic deleted the yarikoptic:enh-coverallsbadge branch Jun 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment