New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetcher for ivim data, needs md5 #1078

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@sahmed95
Contributor

sahmed95 commented Jun 12, 2016

Needs the hashes, but otherwise good to go. This is for the upcoming ivim module currently being developed in #1058.

Shahnawaz Ahmed
@coveralls

This comment has been minimized.

coveralls commented Jun 12, 2016

Coverage Status

Coverage decreased (-0.03%) to 82.831% when pulling a9f71cd on sahmed95:fetcher_ivim into 0296f97 on nipy:master.

Shahnawaz Ahmed
@coveralls

This comment has been minimized.

coveralls commented Jun 12, 2016

Coverage Status

Coverage decreased (-0.03%) to 82.831% when pulling a478b21 on sahmed95:fetcher_ivim into 0296f97 on nipy:master.

@arokem

This comment has been minimized.

Member

arokem commented Jun 12, 2016

This looks good to me, but would you mind merging this into #1055 instead of having us merge this directly into master at this point? That way, we can prepare everything up to and including the IVIM example on that branch, and then merge it all together.

@sahmed95

This comment has been minimized.

Contributor

sahmed95 commented Jun 12, 2016

@arokem I think you meant #1058

@arokem

This comment has been minimized.

Member

arokem commented Jun 12, 2016

I did indeed!

root
@sahmed95

This comment has been minimized.

Contributor

sahmed95 commented Jun 13, 2016

This is included in #1058

@sahmed95 sahmed95 closed this Jun 13, 2016

@coveralls

This comment has been minimized.

coveralls commented Jun 13, 2016

Coverage Status

Coverage decreased (-0.02%) to 82.837% when pulling 88f113f on sahmed95:fetcher_ivim into 0296f97 on nipy:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment