New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced workflows #1085

Closed
wants to merge 131 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@matthieudumont
Contributor

matthieudumont commented Jun 22, 2016

  • Enhanced the workflow system.
  • Added workflows for denoising, dti reconstruction, csa reconstruction, csd recontruction.
  • Streamline related workflows / combined workflows are not included in this PR, waiting on nibabel's streamline api to be officially out.
    -Added combined workflows (pipelines).
    -Tests for workflows, combined workflows, flow_runner, argparser and io iterator. The plan is to test the processing workflows results through dipy_qa.
    -Examples on how to create a workflow and a combined workflow.
@arokem

This comment has been minimized.

Member

arokem commented Jun 22, 2016

This PR is too large to be reviewed (>2000 LOC!).

Any chance you can break this down into a few different branches? From your description, it seems amenable to that (e.g, one branch for each workflow).

@MarcCote

This comment has been minimized.

Contributor

MarcCote commented Jun 22, 2016

I agree with @arokem. I found out the hard way with the Nibabel's streamlines API.

That said, for a start the script bin/dipy_quickbundles has been deleted but it is still listed under the scripts section of the setup.py.

@matthieudumont

This comment has been minimized.

Contributor

matthieudumont commented Jun 22, 2016

Allright ill try to split it out the best I can. back with another one soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment