Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Updates to FBC measures documentation #1094
Removed some import lines that weren't used. Added a fixed seed for reproducibility.
I was asked to fix PEP8 in this line
However the PEP8 checker I'm using doesn't complain about this line. Should it be changed to this?
Current coverage is 80.84%
@@ master #1094 diff @@ ========================================== Files 200 200 Lines 23023 23023 Methods 0 0 Messages 0 0 Branches 2309 2309 ========================================== Hits 18614 18614 Misses 3933 3933 Partials 476 476
Hi @stephanmeesters : thanks for making these changes. I use flake8 to lint my Python code. For this file, it will complain about some trailing white-space, and about some module-level imports . I wouldn't worry about either of these too much (though you might want to configure your text editor to eliminate trailing white-space).
Here's a couple you might want to fix, though
As for the line you mentioned, I am not getting any