New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: add pytables to travis-ci, Py35 full test run #1102

Merged
merged 3 commits into from Jul 29, 2016

Conversation

Projects
None yet
4 participants
@matthew-brett
Member

matthew-brett commented Jul 28, 2016

Add a Python 3.5 run with full dependendencies. Add (py)tables to full
dependencies.

Replaces #1101.

@coveralls

This comment has been minimized.

coveralls commented Jul 28, 2016

Coverage Status

Coverage remained the same at 82.908% when pulling 28da008 on matthew-brett:add-pytables-test into c09a194 on nipy:master.

@codecov-io

This comment has been minimized.

codecov-io commented Jul 28, 2016

Current coverage is 80.84% (diff: 100%)

Merging #1102 into master will not change coverage

@@             master      #1102   diff @@
==========================================
  Files           200        200          
  Lines         23023      23023          
  Methods           0          0          
  Messages          0          0          
  Branches       2309       2309          
==========================================
  Hits          18614      18614          
  Misses         3933       3933          
  Partials        476        476          

Powered by Codecov. Last update c09a194...8759699

.travis.yml Outdated
apt:
packages:
# For runs with pytables
- libhdf5-serial

This comment has been minimized.

@arokem

arokem Jul 29, 2016

Member

Maybe libhdf5-serial-dev ?

This comment has been minimized.

@matthew-brett

This comment has been minimized.

@arokem

arokem Jul 29, 2016

Member

Because it looks like apt-get is not finding this one.

This comment has been minimized.

@arokem arokem referenced this pull request Jul 29, 2016

Merged

Fix for Python 3 in io.dpy #1100

TST: add pytables to travis-ci, Py35 full test run
Add a Python 3.5 run with full dependendencies.  Add (py)tables to full
dependencies.

@matthew-brett matthew-brett force-pushed the matthew-brett:add-pytables-test branch from 28da008 to d2bbc8a Jul 29, 2016

@matthew-brett

This comment has been minimized.

Member

matthew-brett commented Jul 29, 2016

OK - changed that line - thanks.

@coveralls

This comment has been minimized.

coveralls commented Jul 29, 2016

Coverage Status

Coverage remained the same at 82.908% when pulling d2bbc8a on matthew-brett:add-pytables-test into c09a194 on nipy:master.

@arokem

This comment has been minimized.

Member

arokem commented Jul 29, 2016

OK - looks like it's doing the right thing:

https://travis-ci.org/nipy/dipy/jobs/148199298#L1981

(we expect this to fail currently, see #1100)

OTOH, these look legit too:

https://travis-ci.org/nipy/dipy/jobs/148199293
https://travis-ci.org/nipy/dipy/jobs/148199294

I am actually getting these on my laptop as well. It looks like some warning is raised that shouldn't be raised.

BF: This raises a warning on line 367 otherwise.
And that triggers a test-failure.
@arokem

This comment has been minimized.

@arokem

This comment has been minimized.

Member

arokem commented Jul 29, 2016

Now in matthew-brett#4 instead.

Merge pull request #4 from arokem/shm-warning
BF: This raises a warning on line 367 otherwise.
@coveralls

This comment has been minimized.

coveralls commented Jul 29, 2016

Coverage Status

Coverage remained the same at 82.908% when pulling 8759699 on matthew-brett:add-pytables-test into c09a194 on nipy:master.

@arokem arokem merged commit 8759699 into nipy:master Jul 29, 2016

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
codecov/patch 100% of diff hit (target 80.84%)
Details
codecov/project 80.84% (+0.00%) compared to c09a194
Details
coverage/coveralls Coverage remained the same at 82.908%
Details
@arokem

This comment has been minimized.

Member

arokem commented Jul 29, 2016

Superseded by #1100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment