New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import reload function from imp module explicitly for python3 #1105

Merged
merged 2 commits into from Jul 31, 2016

Conversation

Projects
None yet
4 participants
@ghoshbishakh
Member

ghoshbishakh commented Jul 31, 2016

fixes #1104

@coveralls

This comment has been minimized.

coveralls commented Jul 31, 2016

Coverage Status

Coverage remained the same at 82.908% when pulling 2c66247 on ghoshbishakh:py3_restore_dti into 63f6a5f on nipy:master.

@codecov-io

This comment has been minimized.

codecov-io commented Jul 31, 2016

Current coverage is 80.84% (diff: 100%)

Merging #1105 into master will not change coverage

@@             master      #1105   diff @@
==========================================
  Files           200        200          
  Lines         23023      23023          
  Methods           0          0          
  Messages          0          0          
  Branches       2309       2309          
==========================================
  Hits          18614      18614          
  Misses         3933       3933          
  Partials        476        476          

Powered by Codecov. Last update 63f6a5f...2c66247

@arokem

This comment has been minimized.

Member

arokem commented Jul 31, 2016

I'd rather remove the reload from the script. I think it's an unnecessary left over from work debugging this script.

@ghoshbishakh

This comment has been minimized.

Member

ghoshbishakh commented Jul 31, 2016

@arokem okey removing it then

@ghoshbishakh

This comment has been minimized.

Member

ghoshbishakh commented Jul 31, 2016

@arokem looks good?

@arokem arokem merged commit 5edee6b into nipy:master Jul 31, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@coveralls

This comment has been minimized.

coveralls commented Jul 31, 2016

Coverage Status

Coverage decreased (-0.4%) to 82.474% when pulling 609e21e on ghoshbishakh:py3_restore_dti into 63f6a5f on nipy:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment