New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1127 #1129

Merged
merged 5 commits into from Oct 13, 2016

Conversation

Projects
None yet
4 participants
@arokem
Member

arokem commented Oct 11, 2016

This addresses #1127. It seems that scipy optimize returns nans instead of -1 on Windows, for non-converging inputs. This converts these nan results into the expected all -1.

See try_branch here: http://nipy.bic.berkeley.edu/builders/dipy-bdist64-35-win2016/builds/42/steps/shell_11/logs/stdio

Fixed plenty of PEP8 violations while I was at it.

@codecov-io

This comment has been minimized.

codecov-io commented Oct 11, 2016

Current coverage is 81.15% (diff: 53.33%)

Merging #1129 into master will decrease coverage by 0.01%

@@             master      #1129   diff @@
==========================================
  Files           215        215          
  Lines         24370      24375     +5   
  Methods           0          0          
  Messages          0          0          
  Branches       2448       2449     +1   
==========================================
+ Hits          19780      19781     +1   
- Misses         4084       4086     +2   
- Partials        506        508     +2   

Powered by Codecov. Last update c1ba780...0c3488e

@coveralls

This comment has been minimized.

coveralls commented Oct 11, 2016

Coverage Status

Coverage decreased (-0.002%) to 83.231% when pulling e7ece7b on arokem:fix-1127 into c1ba780 on nipy:master.

1 similar comment
@coveralls

This comment has been minimized.

coveralls commented Oct 11, 2016

Coverage Status

Coverage decreased (-0.002%) to 83.231% when pulling e7ece7b on arokem:fix-1127 into c1ba780 on nipy:master.

@coveralls

This comment has been minimized.

coveralls commented Oct 12, 2016

Coverage Status

Coverage decreased (-0.005%) to 83.229% when pulling 0c3488e on arokem:fix-1127 into c1ba780 on nipy:master.

1 similar comment
@coveralls

This comment has been minimized.

coveralls commented Oct 12, 2016

Coverage Status

Coverage decreased (-0.005%) to 83.229% when pulling 0c3488e on arokem:fix-1127 into c1ba780 on nipy:master.

@Garyfallidis Garyfallidis merged commit 1a5f132 into nipy:master Oct 13, 2016

1 of 4 checks passed

codecov/patch 53.33% of diff hit (target 81.16%)
Details
codecov/project 81.15% (-0.02%) compared to c1ba780
Details
coverage/coveralls Coverage decreased (-0.005%) to 83.229%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment