New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .travis.yml and README.md #1132

Merged
merged 1 commit into from Oct 28, 2016

Conversation

Projects
None yet
4 participants
@MarcCote
Contributor

MarcCote commented Oct 15, 2016

This PR:

  • removes coveralls badge from README.md. It is currently displaying unknown and codecov seems better (see https://www.slant.co/versus/7928/7929/~coveralls_vs_codecov).
  • makes sure we use COVERAGE=1 only in one Travis build. Having multiple builds with COVERAGE=1 generate several unnecessary coveralls posts in PRs. Also, currently no builds with COVERAGE=1 were running VTK tests, so the code coverage being reported wasn't accurate.
  • removes unnecessary Travis build which was supposedly testing with VTK6. However, Ubuntu 12.04 (the one use by Travis) doesn't offer the package python-vtk6 (see my comments in #759). So, that particular build was equivalent to another one that wasn't testing VTK code at all.
@arokem

This comment has been minimized.

Member

arokem commented Oct 15, 2016

Yeah. Seems fine to me. I think that the reason we wanted to separately test for coverage with minimum dependency requirements was to cross-check between coverage reports for code where there are alternative paths depending on, for example, the scipy version (core.optimize). But I think that these cases need to be handled by testing in local virtual env anyhow.

@matthew-brett : was there any other reason for this that I don't remember?

@coveralls

This comment has been minimized.

coveralls commented Oct 16, 2016

Coverage Status

Coverage increased (+4.08%) to 87.021% when pulling 13f3192 on MarcCote:change_travis_config into da31980 on nipy:master.

@codecov-io

This comment has been minimized.

codecov-io commented Oct 16, 2016

Current coverage is 84.51% (diff: 100%)

Merging #1132 into master will increase coverage by 3.65%

@@             master      #1132   diff @@
==========================================
  Files           217        217           
  Lines         24593      24593           
  Methods           0          0           
  Messages          0          0           
  Branches       2491       2491           
==========================================
+ Hits          19888      20786    +898   
+ Misses         4194       3192   -1002   
- Partials        511        615    +104   

Powered by Codecov. Last update da31980...13f3192

@arokem

This comment has been minimized.

Member

arokem commented Oct 21, 2016

Anyone have any more thoughts here?

@arokem arokem merged commit ef9c1a6 into nipy:master Oct 28, 2016

4 checks passed

codecov/patch Coverage not affected when comparing da31980...13f3192
Details
codecov/project 84.51% (+3.65%) compared to da31980
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+4.08%) to 87.021%
Details

@MarcCote MarcCote deleted the MarcCote:change_travis_config branch Nov 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment