New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase of https://github.com/nipy/dipy/pull/993 #1134

Merged
merged 5 commits into from Oct 31, 2016

Conversation

Projects
None yet
5 participants
@arokem
Member

arokem commented Oct 21, 2016

Supersedes #993, which seems to have been abandoned.

@coveralls

This comment has been minimized.

coveralls commented Oct 21, 2016

Coverage Status

Coverage remained the same at 82.938% when pulling de4dcd3 on arokem:fix-test into da31980 on nipy:master.

1 similar comment
@coveralls

This comment has been minimized.

coveralls commented Oct 21, 2016

Coverage Status

Coverage remained the same at 82.938% when pulling de4dcd3 on arokem:fix-test into da31980 on nipy:master.

@codecov-io

This comment has been minimized.

codecov-io commented Oct 21, 2016

Current coverage is 80.86% (diff: 100%)

Merging #1134 into master will not change coverage

@@             master      #1134   diff @@
==========================================
  Files           217        217          
  Lines         24593      24593          
  Methods           0          0          
  Messages          0          0          
  Branches       2491       2491          
==========================================
  Hits          19888      19888          
  Misses         4194       4194          
  Partials        511        511          

Powered by Codecov. Last update da31980...de4dcd3

@MarcCote

This comment has been minimized.

Contributor

MarcCote commented Oct 31, 2016

It is a very simple PR that has been opened for a few days now. Everything seems fine. Do you want me to merge it now @arokem ?

@arokem

This comment has been minimized.

Member

arokem commented Oct 31, 2016

Please do!

@MarcCote MarcCote merged commit e3b6b9e into nipy:master Oct 31, 2016

4 checks passed

codecov/patch 100% of diff hit (target 80.86%)
Details
codecov/project 80.86% (+0.00%) compared to da31980
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 82.938%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment