Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
A lightweight UI for medical visualizations #1: Button and Panel #1140
@@ Coverage Diff @@ ## master #1140 +/- ## ========================================== + Coverage 85.8% 85.93% +0.12% ========================================== Files 215 219 +4 Lines 26001 26383 +382 Branches 2668 2706 +38 ========================================== + Hits 22310 22671 +361 - Misses 3038 3052 +14 - Partials 653 660 +7
@skoudoro thank you for your suggestions. @MarcCote and I are currently working on making the API even more simple than what we currently have. I will be incorporating the changes you've suggested in the upcoming commits to this Pull Request.
First few comments. A lot of docstrings are incomplete. The code is running fine on my machine, this is awesome :D
Almost there. Mostly dosctring and PEP8 stuff. I'll have to review the the panel machinery tomorrow.
I did try the code and worked for me. However, you still have many pep8 issues in ui.py (mostly regarding line length). Please do correct those.
Now in test_ui.py if I change the parameter to recording=True I get this warning after closing the window
Which is something not critical but it is good to know that it does exist.