New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not cover files related to benchmarks. #1141

Merged
merged 1 commit into from Nov 3, 2016

Conversation

Projects
None yet
4 participants
@MarcCote
Contributor

MarcCote commented Nov 3, 2016

Right now, benchmarks count towards our coverage but we are not running them on Travis. I suggest we exclude them.

@codecov-io

This comment has been minimized.

codecov-io commented Nov 3, 2016

Current coverage is 85.44% (diff: 100%)

Merging #1141 into master will increase coverage by 0.60%

@@             master      #1141   diff @@
==========================================
  Files           221        214     -7   
  Lines         25169      24901   -268   
  Methods           0          0          
  Messages          0          0          
  Branches       2542       2524    -18   
==========================================
- Hits          21354      21277    -77   
+ Misses         3176       2993   -183   
+ Partials        639        631     -8   

Powered by Codecov. Last update 0548479...0a4740d

@coveralls

This comment has been minimized.

coveralls commented Nov 3, 2016

Coverage Status

Coverage increased (+0.6%) to 87.98% when pulling 0a4740d on MarcCote:change_codecov_config into 0548479 on nipy:master.

@arokem

This comment has been minimized.

Member

arokem commented Nov 3, 2016

Yeah. Get it up in the 90s!

@arokem arokem merged commit e8eeb70 into nipy:master Nov 3, 2016

4 checks passed

codecov/patch Coverage not affected when comparing 0548479...0a4740d
Details
codecov/project 85.44% (+0.60%) compared to 0548479
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.6%) to 87.98%
Details

@MarcCote MarcCote deleted the MarcCote:change_codecov_config branch Nov 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment