New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DKI_signal to dki_signal #1149

Merged
merged 1 commit into from Nov 15, 2016

Conversation

Projects
None yet
5 participants
@RafaelNH
Contributor

RafaelNH commented Nov 13, 2016

To address Issue #1145

@RafaelNH RafaelNH changed the title from Changes DKI_signal to dki_signal in dipy.sims.voxel and respective tests to Change DKI_signal to dki_signal Nov 13, 2016

@codecov-io

This comment has been minimized.

codecov-io commented Nov 13, 2016

Current coverage is 85.44% (diff: 100%)

Merging #1149 into master will not change coverage

@@             master      #1149   diff @@
==========================================
  Files           214        214          
  Lines         24904      24904          
  Methods           0          0          
  Messages          0          0          
  Branches       2526       2526          
==========================================
  Hits          21279      21279          
  Misses         2993       2993          
  Partials        632        632          

Powered by Codecov. Last update 7302303...1ff1184

@coveralls

This comment has been minimized.

coveralls commented Nov 13, 2016

Coverage Status

Coverage remained the same at 87.982% when pulling 1ff1184 on RafaelNH:dki_signal into 7302303 on nipy:master.

@RafaelNH

This comment has been minimized.

Contributor

RafaelNH commented Nov 14, 2016

@Garyfallidis - any comments?

@arokem

This comment has been minimized.

Member

arokem commented Nov 14, 2016

Do we need to do something for back-compatibility and deprecation

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Nov 15, 2016

Question. No tutorial or other test is using this function?

@arokem

This comment has been minimized.

Member

arokem commented Nov 15, 2016

Not as far as I can tell (git grep DKI_signal)

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Nov 15, 2016

Okay thanks. This is a minor change so I am going to merge...

@Garyfallidis Garyfallidis merged commit eec397d into nipy:master Nov 15, 2016

4 checks passed

codecov/patch 100% of diff hit (target 85.44%)
Details
codecov/project 85.44% (+0.00%) compared to 7302303
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 87.982%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment