New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csa and csd reconstruction workflow #1155

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@matthieudumont
Contributor

matthieudumont commented Nov 25, 2016

No description provided.

@coveralls

This comment has been minimized.

coveralls commented Nov 28, 2016

Coverage Status

Coverage increased (+0.04%) to 88.044% when pulling a991c54 on matthieudumont:csa_csd_workflow into e87b327 on nipy:master.

@codecov-io

This comment has been minimized.

codecov-io commented Nov 28, 2016

Current coverage is 85.47% (diff: 85.79%)

Merging #1155 into master will increase coverage by <.01%

@@             master      #1155   diff @@
==========================================
  Files           214        216     +2   
  Lines         24917      25093   +176   
  Methods           0          0          
  Messages          0          0          
  Branches       2526       2540    +14   
==========================================
+ Hits          21296      21448   +152   
- Misses         2989       2998     +9   
- Partials        632        647    +15   

Powered by Codecov. Last update e87b327...a991c54

@coveralls

This comment has been minimized.

coveralls commented Nov 28, 2016

Coverage Status

Coverage increased (+0.04%) to 88.044% when pulling a991c54 on matthieudumont:csa_csd_workflow into e87b327 on nipy:master.

else:
save_func = np.savez
save_func(fname,

This comment has been minimized.

@Garyfallidis

Garyfallidis Dec 1, 2016

Member

Hi @matthieudumont I had one user strongly suggesting to use hdf5 to save the peaks rather than npy or npz. This will allow other non-pythonic projects to read our results. We already depend on pytables that allows to save to hdf5. So, it shouldn't be difficult to make the change. If you agree I can make a PR on top of yours with the required changes. Or if you know how to do it and agree with the suggestion you can go ahead and make the change yourself. See also here https://github.com/nipy/dipy/pull/1147/files
Let me know what you think.

This comment has been minimized.

@matthieudumont

matthieudumont Dec 1, 2016

Contributor

I think it is a great idea!

Ill let you make the PR and concentrate on the ones I have already running.

Thanks!

This comment has been minimized.

@Garyfallidis

Garyfallidis Dec 1, 2016

Member

okay sure.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Feb 17, 2017

Hi @matthieudumont, now that we have merged the mask workflow we have some conflicts here. Can you please resolve?

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Jun 13, 2017

Resolved here #1241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment