New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: closing matplotlib plots for each file while running the examples #1158

Merged
merged 1 commit into from Nov 30, 2016

Conversation

Projects
None yet
6 participants
@Garyfallidis
Member

Garyfallidis commented Nov 30, 2016

It seems that although I was deleting the namespaces, the matplotlib plots were not deleted. This PR should hopefully fix this problem reported in issue #1154

@coveralls

This comment has been minimized.

coveralls commented Nov 30, 2016

Coverage Status

Coverage remained the same at 88.004% when pulling 9664dce on Garyfallidis:readd_plot_close into e87b327 on nipy:master.

@codecov-io

This comment has been minimized.

codecov-io commented Nov 30, 2016

Current coverage is 85.46% (diff: 100%)

Merging #1158 into master will not change coverage

@@             master      #1158   diff @@
==========================================
  Files           214        214          
  Lines         24917      24917          
  Methods           0          0          
  Messages          0          0          
  Branches       2526       2526          
==========================================
  Hits          21296      21296          
  Misses         2989       2989          
  Partials        632        632          

Powered by Codecov. Last update e87b327...9664dce

@arokem

This comment has been minimized.

Member

arokem commented Nov 30, 2016

Did you try running the documentation build with this? Does it work?

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Nov 30, 2016

Of course I did. Yes, it works. See here :)
image

After you merge this. Will run the docs one more time on master and update the current website.

@arokem arokem merged commit e1632e2 into nipy:master Nov 30, 2016

4 checks passed

codecov/patch Coverage not affected when comparing e87b327...9664dce
Details
codecov/project 85.46% (+0.00%) compared to e87b327
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 88.004%
Details
@arokem

This comment has been minimized.

Member

arokem commented Nov 30, 2016

The problem with running the doc build from master is that it is far advanced since our last release, which will confuse some users who have installed that release. I see two options here:

  1. Cut a new release .
  2. Merge this fix into maint/0.11.x and build the docs from there.

I like the first one (it's been a while...), but it's slightly more time-consuming.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Nov 30, 2016

Okay thanks. Will let you know when the website is updated.

@arokem

This comment has been minimized.

Member

arokem commented Nov 30, 2016

On the plus side, the bots look to be green on current master.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Nov 30, 2016

The website is updated. Check here http://nipy.org/dipy/examples_built/streamline_tools.html#example-streamline-tools please also look a bit around in the other tutorials to see if math and pictures are good too.

@arokem

This comment has been minimized.

Member

arokem commented Dec 1, 2016

@jchoude

This comment has been minimized.

Contributor

jchoude commented Dec 1, 2016

I think this is quite problematic, since we have a few users to whom something similar already happened with other releases...

Also, @Garyfallidis what's the status of the website deployment on your host? I guess @ghoshbishakh is quite busy with school. That would allievate this kind of issues.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Dec 1, 2016

The new website is ready to be deployed. Here is a temporary link http://elef.soic.indiana.edu
We need to send pictures to @ghoshbishakh and see if any small PRs are needed to be merged in dipy_web. Then we can make the change.
I think we should release DIPY relatively soon. Before Christmas. I am a bit worried that some of the PRs have waited for some time and some of the important bugs (like the memory issue with streamlines) need to be resolved before the release.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Dec 1, 2016

The pictures are for the carousel. I have some in mind but it would nice if more artwork is shown.

@ghoshbishakh

This comment has been minimized.

Member

ghoshbishakh commented Dec 1, 2016

my semester exams will be going on till 16th December. But let me know if I need to update something in dipy_web or update the docs.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Dec 2, 2016

@arokem and @jchoude good points let me put the website back to release 0.11.0 but with the tutorials properly shown.

@ghoshbishakh that is okay. Please focus on your exams.

@jchoude

This comment has been minimized.

Contributor

jchoude commented Dec 2, 2016

@Garyfallidis Thanks :)

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Dec 2, 2016

Okay! Done! You are welcome @jchoude thanks for the hint! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment